Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor recipe updates #46

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Minor recipe updates #46

merged 6 commits into from
Feb 16, 2022

Conversation

Anthchirp
Copy link
Member

@Anthchirp Anthchirp commented Jan 26, 2022 •
edited
Loading

I noted that pip check fails downstream of a pytype installation. Turns out that the pytype package is not to blame, but here are a couple of recipe updates anyway:

  • Add 'pip check' to tests
  • There are no Python <=3.6 builds any more
  • Drop the now no-op dataclasses dependency
  • Sync remaining dependencies with upstream

Haven't rerendered yet, as this PR is currently blocked by conda-forge/ninja-feedstock#26 anyway

Checklist

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Anthchirp
Recipe updates
0ebb3ed 
* Increment build number
* There are no Python <=3.6 builds any more
* Drop the now no-op dataclasses dependency
* Sync remaining dependencies with upstream
@Anthchirp Anthchirp changed the title Add 'pip check' to tests Minor recipe updates Jan 26, 2022
@Anthchirp Anthchirp mentioned this pull request Jan 26, 2022
Open
@Anthchirp
Remove pip check again
8657a9b 
as the issue is with the ninja package not including the python package,
but this is unlikely to be fixed any time soon.
@Anthchirp
Copy link
Member Author

The problem I came here to solve is documented in conda-forge/ninja-feedstock#26, but it is messy and unlikely to be fixed soon. So I have removed the pip check again for now, but the rest of the recipe changes can still be merged.

@conda-forge-admin, please rerender

@ngam
Copy link
Contributor

ngam commented Jan 26, 2022

The problem I came here to solve is documented in conda-forge/ninja-feedstock#26, but it is messy and unlikely to be fixed soon

Damn!

@ngam
Copy link
Contributor

ngam commented Jan 26, 2022

I will happily merge this soon, just giving @marcelotrevisani time to see/review it. Would you like to add yourself as a maintainer, @Anthchirp?

@Anthchirp
Copy link
Member Author

Yes, happy to keep an eye on the pytype package 👍

@Anthchirp
Copy link
Member Author

@conda-forge-admin, please rerender

marcelotrevisani
marcelotrevisani reviewed Jan 26, 2022
View reviewed changes
recipe/meta.yaml
@@ -44,14 +44,13 @@ requirements:
- python
Copy link
Member

@marcelotrevisani marcelotrevisani Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it need pybind11?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/google/pytype/blob/07662febd183e4a3395e05ea8d3adf75397bd7cb/pyproject.toml#L2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this is passing without it: https://github.com/google/pytype/blob/07662febd183e4a3395e05ea8d3adf75397bd7cb/setup.py#L18-L24

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pulling in a pybind11 folder in line 16? I didn't look into the extra files.
Looking at them now - those are not actually patch sets but are pulling in some specific commit revisions of googletest, pybind11, and typeshed. These probably should be build-/test-time dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! https://github.com/Anthchirp/pytype-feedstock/blob/f811a2dd93459a3cf28ea5fdb853814388ca2c19/recipe/meta.yaml#L13-L21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you wanna unvendor these or nah?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no real need --- the pkg doesn't end up taking these deps with it; they're just needed at build time, I believe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be neater to unvendor, but I feel that's a separate endeavour

@marcelotrevisani marcelotrevisani merged commit 3a34c3e into conda-forge:master Feb 16, 2022
@Anthchirp Anthchirp deleted the fix-pip-check branch February 16, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelotrevisani marcelotrevisani marcelotrevisani left review comments

@ngam ngam ngam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anthchirp @conda-forge-linter @ngam @marcelotrevisani